Skip to content

Conversation

kprotty
Copy link
Contributor

@kprotty kprotty commented Oct 1, 2025

based on #942

@github-project-automation github-project-automation bot moved this to 🏗 In progress in Sig Oct 1, 2025
@kprotty kprotty self-assigned this Oct 1, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Oct 1, 2025
@kprotty kprotty changed the base branch from main to Rexicon226/zksdk-refactor October 2, 2025 16:53
@kprotty kprotty marked this pull request as ready for review October 2, 2025 16:54
@kprotty kprotty requested review from ultd, dnut and yewman as code owners October 2, 2025 16:54
@Rexicon226 Rexicon226 force-pushed the Rexicon226/zksdk-refactor branch from d8b3db7 to 38cb0bd Compare October 2, 2025 19:30
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/runtime/program_loader.zig 83.33% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
src/runtime/program_loader.zig 89.58% <83.33%> (-0.37%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rexicon226
Copy link
Contributor

Feel free to merge anytime, codecov doesn't need to pass to merge into zksdk PR.

@kprotty kprotty merged commit 7491104 into Rexicon226/zksdk-refactor Oct 3, 2025
17 of 18 checks passed
@kprotty kprotty deleted the king/fix-3.0.3 branch October 3, 2025 13:26
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Sig Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants