Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit CMake version check in case of Gadgetron testing ON #854

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Feb 1, 2024

Adds an explicit check of CMake version and message(FATAL_ERROR) if CMake version is below 3.23.

Closes #823

@paskino paskino changed the title Gadgetron testing Add explicit CMake version check in case of Gadgetron testing ON Feb 1, 2024
@KrisThielemans
Copy link
Member

The job is going through, but that'll be because CMake is more recent presumably, so you can just as well keep an job with the testing on.

To test if the lines are ok, I guess you'll need an older CMake...

@KrisThielemans
Copy link
Member

confirmed with CMake 3.10

Make Error at SuperBuild/External_Gadgetron.cmake:141 (message):
  You need at least CMake 3.23 to build Gadgetron tests.

@KrisThielemans
Copy link
Member

sadly unrelated error https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/7740032215/job/21104114360?pr=854#step:8:9340

CMake Error at /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/TBB-prefix/src/TBB-stamp/TBB-build-Release.cmake:49 (message):
  Command failed: 2

   'make' 'compiler=gcc' 'cpp0x=1' 'CXXFLAGS= -mno-rtm' 'CPLUS=/usr/lib/ccache/g++-11' 'CONLY=/usr/lib/ccache/gcc-11' 'LDFLAGS='
  See also
    /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/TBB-prefix/src/TBB-stamp/TBB-build-*.log

No idea about that.

As it's unrelated, I vote for merging this PR anyway, after cleaning up the jobs.

@paskino paskino merged commit 2ef4651 into master Feb 2, 2024
10 of 12 checks passed
@paskino paskino deleted the Gadgetron_testing branch February 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

building Gadgetron with testing requires CMake 3.23 (missing target GTest::gmock)
2 participants