-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shairport #3866
base: master
Are you sure you want to change the base?
Fix shairport #3866
Conversation
@hgy59 From my point of view, we may discard DSM 5 support here. Probably it helps to deliver this update. |
Nice job getting shairport-sync building happily :) looking forward to it landing in the package repo. |
@cortices can you test this package with your diskstation as I have no speaker to validate it is working? I uploaded a pre-release in my forked repo here |
I have installed the prerelease on my DS918+ (x64). It installs and runs fine and devices connect to it however there is no sound coming from the device. Confirmed using AirPlay from 1 Mac, 1 iPhone, and from the synology Audio Station itself. Not certain where I can locate clearer logs/enable verbose options, since |
Please have a look at The alsa config files are located in Unfortunately there is no older shairport-sync package available that could be used to validate that it once worked as expected. Validate ports with:
As analyzing this, I found that port 5353 is not configured for DSM by now. |
I am updating the prerelease with the port 5353 fix here |
Sorry, the port 5353 fix was a bad solution. With this it sould be possible to find the delta to the updated version that is not found as output device yet. |
I've set the log verbosity to 2 and then 3 in the config file and restarted with I do have all 3 ports appearing in netstat output as you indicated. |
See some logging when I stop shairport-sync and manually run it on command line like this: # cd /var/packages/shairport-sync/target/bin
# ./shairport-sync -v -v -v --configfile=../var/shairport-sync.conf Then I can see errors, but have no idea what it is about:
|
Okay cool, I got proper logging by running it separately. When the AirPlay device connects there's a bunch of logs of them negotiating and setting parameters, and then the relevant errors begin:
This block repeats as shairport-sync attempts to pipe control & PCM data to ALSA. Clearly I need to do some more research on how ALSA works on Synology's cutdown Debian. |
And this is the full log:
it looks like this is the problem:
|
Still no success:
Running as service puts the following to
So I suppose the service must be run as root, and this will forbidden on DSM 7. |
the spk from #3866 (comment) works for me after changing the device to "hw:Device" in config file and giving /dev/snd recursively chmod 777 I'am on DSM 6.1 |
can you build an spk with version 3.3.9 ? @hgy59 |
I can rebase this branch and push so the github action will create the packages. But it does not support DSM 6.1 anymore. Since Synology retired the older toolchains we build for DSM 6 for Version 6.2.4 only. But I still have those toolchains locally. What is you model? Can you update to DSM 6.2.4? |
I am on 6.1.7 but currently I can’t update to 6.2. do you mean that you can’t build a version prior 6.2.4? |
What is your model? DSM 6.2.4 is available for almost all models (except EDS14, limitid to DSM 6.0.3-8754). I can locally build for DSM 6.1 with the 6.1 toolchains in my cache. EDIT: I can provde packages for shairport-sync 3.3.9 and DSM 6.1. |
you find it here |
I will try and give feedback. Thank you so much |
It worked now for more then a week. no crashed or other problems. again: thank you so much |
@blendR8 thank you for the feedback. Just for clarification: do you stream to speakers attached to the Diskstation? |
- update to DSM6 service configuration - fix pid file creation (configure option --with-piddir has no effect, default location is var/run) - create start-stop-status functions base on projects systemv template - add busybox module usrmng (otherwise busybox install fails for unknown reason) - create soft links with busybox install - include all documented settings in shaiport-sync.conf - TODO: fix DSM5 installation
- use daemonize and remove busybox start-stop-service - use generic SERVICE_COMMAND - add patch to compile for ppc853x
- update shairport-sync - adjust config for DSM 7 - add soxr support - add convolution filter support except for old compilers - migrate from openssl to mbedtls
- update mbedtls to v2.28.6 - adjust config (daemon_pid_dir is still required, despite it got removed in sample config)
Motivation: Shairport-sync DSM6 compatibiliy is asked a long time ago
Linked issues: #3040 (with links to other issues), fixes #3922
Checklist
all-supported
completed successfully (except for ppc853x-5.2)Remarks