Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpng: Fix cmake args and disable static library #5880

Merged
merged 1 commit into from
Sep 13, 2023
Merged

libpng: Fix cmake args and disable static library #5880

merged 1 commit into from
Sep 13, 2023

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Sep 13, 2023

Description

libpng: Fix cmake args and disable static library. This in turns allow building with debug_symbols enabled.

Relates to #5879

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 mentioned this pull request Sep 13, 2023
Merged
10 tasks
hgy59
hgy59 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we can merge, and must not run the github build action again

@hgy59 hgy59 merged commit 1d690d4 into SynoCommunity:master Sep 13, 2023
@th0ma7 th0ma7 deleted the libpng-cmake-fix branch September 13, 2023 19:04
@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 13, 2023

I was about to do the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgy59 hgy59 hgy59 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th0ma7 @hgy59