Update Gitea to v1.20.6

[wkobiela]

Description

Checklist

• Build rule all-supported completed successfully
• New installation of package completed successfully
• Package upgrade completed successfully (Manually install the package again)
• Package functionality was tested
• Any needed documentation is updated/created

Type of change

• Bug fix
• New Package
• Package update
• Includes small framework changes
• This change requires a documentation update (e.g. Wiki)

[efussi]

@hgy59 Can you please review this PR (and merge, if it's ok)?

[hgy59]

gitea package should use the redesigned shared folder handling to fix #5481

• use SERVICE_WIZARD_SHARENAME instead of SERVICE_WIZARD_SHARE
• adjust the install wizard to ask for the share name only
• remove USE_DATA_SHARE_WORKER = yes (it is not used when SERVICE_WIZARD_SHARENAME is defined)
• validate that on package upgrade the etc/installer-variables file variables SHARE_PATH and SHARE_NAME are correct (might need migration code) this is not mandatory, but would be required when an upgrade wizard will be added

The current spk/demoservice code can be used as an example of new shared folder handling.

[wkobiela]

I think that I updated these points

• use SERVICE_WIZARD_SHARENAME instead of SERVICE_WIZARD_SHARE
• adjust the install wizard to ask for the share name only
• remove USE_DATA_SHARE_WORKER = yes (it is not used when SERVICE_WIZARD_SHARENAME is defined)

Unfortunately, for now I don't have an option to test this package

[hgy59]

Unfortunately, for now I don't have an option to test this package

@wkobiela I did a fresh installation of the published gitea 1.17.3-10 on DSM 7.2.1 (virtual DSM x86_64).
The initial etc/installer-variables file has one entry

SHARE_PATH=/volume1/gitea

Then I did an update to 1.20.5-11 with the package built by latest github build action.
It took some time until the web ui got available after the update (gitea log shows that the db migration took ~ 15 sec., but it seemed like 2-3 minutes to get the ui back).
The etc/installer-variables file after update looks good:

SHARE_PATH=/volume1/gitea
SHARE_NAME=gitea

There are two configuration issues with this update, displayed on the configuration page:

1. lfs path
   Deprecated config option [server] LFS_CONTENT_PATH present. Use [lfs] PATH instead. This fallback will be/has been removed in v1.19.0 (and 2 more)

   To solve this, I had to remove the LFS_CONTENT_PATH in the [server] section (the PATH in the [lfs] section was already set with the LFS_CONTENT_PATH value) in the conf.ini file.
   To get rid of the warning I had to restart gitea (in the package center or with command line tool synopkg)

   Then the next warning/error popped up on the configuration page:

2. router log
   Deprecated config option [log] ROUTER present. Use [log] logger.router.MODE instead. This fallback will be/has been removed in 1.21

   As the text says, I had to rename ROUTER to logger.router.MODE in the [log] section.

   To get rid of the warning I had to restart gitea again.

I don't know whether it is worth to add upgrade code in the service-setup.sh script to migrate the confi.ini file (sounds sophisticated).
Another attempt would be to add an upgrade wizard page, telling that manual configuration changes are needed after package upgrade and a manual service restart is required to apply the changes.
Or - if manual adjustments are the regular case for gitea updates - we could leaf it as is.

Anyway, it is time to add a FAQ page for the gitea package in our wiki. at least to document the location of the configuration file at:
/var/packages/gitea/var/conf.ini

[hgy59]

@wkobiela second test with a new installation of gitea 1.20.5-11 built by latest github build action.

The installed conf.ini file is still deprecated.

I propose to add a var/conf.ini file to the package with placeholders for the wizard variables and not to generate the file in service-setup.sh.
For DSM 7 this works like a charm and an existing conf.ini file is not touched on upgrade but the file of the new installation package is installed with the name conf.ini.new.
For DSM 6 it needs some backup/restore code to not overwrite conf.ini of the former installation.

Hints:
You should not need to use ${wizard_shared_folder_name} in service-setup.sh. You can use the variable SHARE_PATH.

For DSM 6 the home folder SYNOPKG_PKGHOME="${SYNOPKG_PKGDEST}" must be replaced by SYNOPKG_PKGHOME="${SYNOPKG_PKGVAR}" or a subfolder of ${SYNOPKG_PKGVAR}. Otherwise the content gets lost on package updates.

The service_preinst function must be removed. With the redesigned shared folder handling the creation of the shared folder is done by DSM data share worker (including the folder permissions) for DSM 6 too.

[wkobiela]

@hgy59 thank you for your tests and detailed description. I'm kind of fresh with deeply modifying synology packages, but tried to implement your thoughts. I hope we are going in a right direction.

I will try to setup xpenology in the meantime to test this package myself.

[wkobiela]

Tested fresh install on Xpenology DVA3221 DSM 7.1-42661 Update 1 - works OK.
Tested manual upgrade on Xpenology DVA3221 DSM 7.1-42661 Update 1 from actual 1.17 package to 1.20.5 - upgrade works OK. Need some minor manual adjustments in conf.ini file and package restart as you mentioned, but other than that works fine. I will change a little description in upgrade_uifile to be more understandable.

Do not have an option to test on DSM6 now

[efussi]

@wkobiela while this PR is stil in progress, should we right away bump to Gitea v1.20.6 which was just released (https://github.com/go-gitea/gitea/releases/tag/v1.20.6)?

[wkobiela]

Tested fresh install on Xpenology DVA3221 DSM 7.1-42661 Update 1 - works OK.
Tested manual upgrade on Xpenology DVA3221 DSM 7.1-42661 Update 1 from actual 1.17 package to 1.20.6 - upgrade works OK.

Do not have an option to test on DSM6 now - is there someone who can help clean install and upgrade on DSM6?

[wkobiela]

Is here everything ok? Can we merge it?

[hgy59]

@mreid-tt can you please have a look here at the update of the shared folder (with the findings of #5962).

[hgy59]

@wkobiela there is a translation of the wizard page to plk in #5700. Can we add (and probably adjust) this here?

[wkobiela]

@hgy59 added translation, is there anything more I can do?

[Bruno21]

Sorry if it's the wrong place to post. I'm unable to install gitea with a mariadb database (Synology package). I'm trying port 3006/3007, localhost/127.0.0.1.
I have to use SQLite

[wkobiela]

Sorry if it's the wrong place to post. I'm unable to install gitea with a mariadb database (Synology package). I'm trying port 3006/3007, localhost/127.0.0.1. I have to use SQLite

I just installed package and connected it with mariadb package - default port is 3306 not 3006:

[hgy59]

obsoleted by #5929