Enhance debug_info symbols + libatomic in wheels (follows-up to #5879) #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also includes: - enforce checking for libatomic.so within python wheels - allow looping over multiple toolchain libraries as needed
- NOT when testing all wheels - NOT when including debug_info symbols - NOT when using PPC arch (fails on qoriq)
hgy59
reviewed
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes :
debug_infosymbols enablement where as at strip time symbols would be removed in some caseslibatomic.sois neededIn turns this removes unrelated changes from #5879 in order for it to solely focus on the qoriq rust issue.
Checklist
all-supportedcompleted successfullyType of change