Skip to content

Framework: Fix to handle empty matrix#6369

Merged
mreid-tt merged 1 commit intoSynoCommunity:masterfrom
mreid-tt:fix-build-matrix
Jan 2, 2025
Merged

Framework: Fix to handle empty matrix#6369
mreid-tt merged 1 commit intoSynoCommunity:masterfrom
mreid-tt:fix-build-matrix

Conversation

@mreid-tt
Copy link
Copy Markdown
Contributor

@mreid-tt mreid-tt commented Jan 2, 2025

Description

This PR introduces a conditional check to skip the build action when no dependent packages are identified, optimizing workflow efficiency and avoiding unnecessary builds.

Relates to #6366

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@mreid-tt mreid-tt self-assigned this Jan 2, 2025
@mreid-tt mreid-tt requested a review from hgy59 January 2, 2025 21:40
Copy link
Copy Markdown
Contributor

@hgy59 hgy59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreid-tt mreid-tt merged commit 5fe5ba6 into SynoCommunity:master Jan 2, 2025
@mreid-tt mreid-tt deleted the fix-build-matrix branch January 2, 2025 23:14
@hgy59
Copy link
Copy Markdown
Contributor

hgy59 commented Jan 2, 2025

@mreid-tt as you can see in https://github.com/SynoCommunity/spksrc/actions/runs/12590111009 it works.

The real reason is that no packages are to build, but I can accept this solution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants