-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] wheel.mk: Migrate to using status cookie #6389
base: master
Are you sure you want to change the base?
Conversation
Functionality for |
@th0ma7 it would be convenient having a
just my 5 cents 🪙 |
@hgy59 If you have a moment to test things up would be great. Similarly to
This will add that "wheel" to the list of wheels to process. Noting that
I'm sure there will be a few rough-edges and missing is the ability to download only for using with github-action (next on my TODO). |
# post_wheel_compile_target (override with POST_WHEEL_COMPILE_TARGET) | ||
# Variables: | ||
# REQUIREMENT Requirement formatted wheel information | ||
# WHEEL_NAME Name of wheel to process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to document, that WHEEL_NAME must not contain -
?
Since name and version are separated by -
the name must not contain -
.
can we add a check here
or fail if name has -
instead of _
or implement an auto renaming?
or can we still use =
as version separator? (can't remeber which make file is affected).
# $(MSG) requirement: [$(REQUIREMENT)] ; \ | ||
# $(MSG) requirement-grep-egg: [$$(grep -s egg <<< $(REQUIREMENT))] ; \ | ||
# $(MSG) name: [$(WHEEL_NAME)] ; \ | ||
# $(MSG) type: [$(WHEEL_TYPE)] ; \ | ||
# $(MSG) version: [$(WHEEL_VERSION)] ; \ | ||
# $(MSG) type: [$(WHEEL_TYPE)] ; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this does not work, it might all be commented out (\
wraps all on a single line, and all following the first # is comment)
just a guess
Description
Migrate to using status cookie
Follow-up to #6282, in particular #6282 (comment)
Checklist
all-supported
completed successfullyType of change
smallframework changesTODO
WHEELS="<name>-<version>" make wheel-<arch>-<tcversion>
distrib/pip
all types (abi3
,crossenv
,pure
)