Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing coverage #88

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Improve testing coverage #88

merged 15 commits into from
Jul 30, 2024

Conversation

marcus-snx
Copy link
Collaborator

@marcus-snx marcus-snx commented Jul 22, 2024

Increase dbt test coverage for basic tests (not_null, unique, recency etc.) and field descriptions.

Next steps:

  • add more advanced tests & have 100% coverage for basic tests
  • create dbt testing DAG in scheduler
  • implement early warning system in Discord/Matrix

Issue: #79

@marcus-snx marcus-snx added the wip Work in progress label Jul 22, 2024
@marcus-snx marcus-snx removed the wip Work in progress label Jul 29, 2024
@marcus-snx marcus-snx requested a review from Tburm July 29, 2024 13:02
data_type: text
tests:
- not_null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is null sometimes, if you check the model we don't specify it when we already have a market symbol for the token.

@Tburm Tburm merged commit c11f447 into main Jul 30, 2024
1 check passed
@Tburm Tburm deleted the feat/dbt-improve-testing branch July 30, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants