-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batchers + build functions #10
Draft
noahlitvin
wants to merge
13
commits into
main
Choose a base branch
from
add-batchers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2eb9c6e
add batchers
5357945
fix: build issue
Rickk137 e8c80ab
Merge branch 'main' into add-batchers
Rickk137 55c6961
fix: eslint issues
Rickk137 cf7e5ca
feat: update multical interface
Rickk137 4996e1c
switch to new library strategy
dbeal-eth d2e064f
testts
dbeal-eth 358d212
add missing files
dbeal-eth 61c024d
more tests, add actions wallet
dbeal-eth e8f967d
feat: update client
Rickk137 f22d6e9
Merge pull request #14 from Synthetixio/batchers-update
dbeal-eth 871727d
0.2.3-0
dbeal-eth 4bc5e9c
1.0.0-0
dbeal-eth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
module.exports = { | ||
"env": { | ||
"browser": true, | ||
"es2021": true, | ||
"node": true | ||
}, | ||
"extends": "standard-with-typescript", | ||
"overrides": [ | ||
{ | ||
"env": { | ||
"node": true | ||
}, | ||
"files": [ | ||
".eslintrc.{js,cjs}" | ||
], | ||
"parserOptions": { | ||
"sourceType": "script" | ||
} | ||
} | ||
], | ||
"parserOptions": { | ||
"ecmaVersion": "latest", | ||
"sourceType": "module" | ||
}, | ||
"rules": { | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
// https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/metatx/ERC2771Context.sol | ||
// SPDX-License-Identifier: MIT | ||
// OpenZeppelin Contracts (last updated v5.0.1) (metatx/ERC2771Context.sol) | ||
pragma solidity ^0.8.20; | ||
|
||
interface IERC2771Context { | ||
function isTrustedForwarder(address forwarder) external view returns (bool); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// https://github.com/bcnmy/scw-contracts/blob/main/contracts/smart-account/SmartAccount.sol | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity 0.8.17; | ||
|
||
interface ISmartAccount { | ||
function executeBatch( | ||
address[] calldata dest, | ||
uint256[] calldata value, | ||
bytes[] calldata func | ||
) external; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// https://github.com/Synthetixio/synthetix-v3/blob/main/auxiliary/TrustedMulticallForwarder/src/TrustedMulticallForwarder.sol | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity 0.8.20; | ||
|
||
interface ITrustedMulticallForwarder { | ||
struct Call3Value { | ||
address target; | ||
bool requireSuccess; | ||
uint256 value; | ||
bytes callData; | ||
} | ||
|
||
struct Result { | ||
bool success; | ||
bytes returnData; | ||
} | ||
|
||
function aggregate3Value( | ||
Call3Value[] calldata calls | ||
) external payable returns (Result[] memory returnData); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one rule I feel like is practically indespensible is no hanging promises https://github.com/usecannon/cannon/blob/main/.eslintrc.json#L55