SIP-324 Passive SNX Pool - Part 1 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeal-eth
approved these changes
Jul 13, 2023
omnibus-optimism-goerli.toml
Outdated
| @@ -48,6 +49,12 @@ defaultValue = "1" | |||
| [setting.sc_pool_owner] | |||
| defaultValue = "0x48914229deDd5A9922f44441ffCCfC2Cb7856Ee9" | |||
|
|
|||
| [setting.snx_pool_id] | |||
| defaultValue = "2" | |||
There was a problem hiding this comment.
Some networks may have pool taken just because it's the next pool Id. Maybe default to something a little more unique?
noisekit
force-pushed
the
SIP-324-Passive-SNX-Pool
branch
from
3f61af3
to
1b1129e
Compare
dbeal-eth
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create pool only. Reward distribution for the pool will be implemented separately
NOTE: waiting for #26 to be merged first