Base goerli #37
Merged
Base goerli #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisekit
commented
Aug 30, 2023
| @@ -19,12 +20,6 @@ defaultValue = "0x48914229deDd5A9922f44441ffCCfC2Cb7856Ee9" | |||
| [setting.weth_address] | |||
| defaultValue = "0x4200000000000000000000000000000000000006" | |||
|
|
|||
| [setting.weth_aggregator_address] | |||
There was a problem hiding this comment.
this setting is not used. eth_aggregator_address is used instead
noisekit
commented
Aug 30, 2023
|
|
||
| # TODO: There is no CCIP token pool available yet, using temporary address | ||
| [setting.ccip_token_pool] | ||
| defaultValue = "0x48914229deDd5A9922f44441ffCCfC2Cb7856Ee9" |
There was a problem hiding this comment.
ccip token pool does not exist yet on base goerli. so leaving bogus address for now
noisekit
force-pushed
the
Base-Goerli
branch
2 times, most recently
from
994ca2c
to
4ea55b5
Compare
noisekit
force-pushed
the
Base-Goerli
branch
from
4ea55b5
to
c756471
Compare
noisekit
force-pushed
the
Base-Goerli
branch
from
c756471
to
73927c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we deploy v3 to Base Mainnet we need to ensure it is fully deployed to Base Goerli.
Here are some Base Goerli deployment updates (mainly adding spot/eth market plus some now available settings) to satisfy SIP-336: Deploy Synthetix V3 Core on Base spec
Deployed https://usecannon.com/packages/synthetix-omnibus/latest/84531-main