Skip to content

Commit

Permalink
update snapshot module (#2254)
Browse files Browse the repository at this point in the history
* update snapshot module

* bump version

* comment

* comment

---------

Co-authored-by: dbeal <[email protected]>
Co-authored-by: Moss <[email protected]>
  • Loading branch information
3 people authored Sep 3, 2024
1 parent 09b8614 commit d03a0ed
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 31 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ contract SnapshotVotePowerModule is ISnapshotVotePowerModule {
bool enabled
) external override {
OwnableStorage.onlyOwner();
Council.onlyInPeriod(Epoch.ElectionPeriod.Administration);
Council.onlyInPeriods(Epoch.ElectionPeriod.Administration, Epoch.ElectionPeriod.Nomination);

SnapshotVotePower.Data storage snapshotVotePower = SnapshotVotePower.load(snapshotContract);
snapshotVotePower.enabled = enabled;
Expand Down
2 changes: 1 addition & 1 deletion protocol/governance/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@synthetixio/governance",
"version": "3.0.7",
"version": "3.0.8",
"description": "On-Chain elections for all Synthetix councils",
"private": true,
"scripts": {
Expand Down
58 changes: 29 additions & 29 deletions protocol/governance/test/integration/Elections.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,35 +237,35 @@ describe('SynthetixElectionModule - Elections', () => {
}
});

describe('when trying to set the snapshot contract', () => {
it('reverts', async () => {
const { mothership, satellite1, satellite2 } = chains;
await assertRevert(
mothership.GovernanceProxy.setSnapshotContract(
mothership.SnapshotRecordMock.address,
0,
true
),
'NotCallableInCurrentPeriod'
);
await assertRevert(
satellite1.GovernanceProxy.setSnapshotContract(
satellite1.SnapshotRecordMock.address,
0,
true
),
'NotCallableInCurrentPeriod'
);
await assertRevert(
satellite2.GovernanceProxy.setSnapshotContract(
satellite2.SnapshotRecordMock.address,
0,
true
),
'NotCallableInCurrentPeriod'
);
});
});
// describe('when trying to set the snapshot contract', () => {
// it('reverts', async () => {
// const { mothership, satellite1, satellite2 } = chains;
// await assertRevert(
// mothership.GovernanceProxy.setSnapshotContract(
// mothership.SnapshotRecordMock.address,
// 0,
// true
// ),
// 'NotCallableInCurrentPeriod'
// );
// await assertRevert(
// satellite1.GovernanceProxy.setSnapshotContract(
// satellite1.SnapshotRecordMock.address,
// 0,
// true
// ),
// 'NotCallableInCurrentPeriod'
// );
// await assertRevert(
// satellite2.GovernanceProxy.setSnapshotContract(
// satellite2.SnapshotRecordMock.address,
// 0,
// true
// ),
// 'NotCallableInCurrentPeriod'
// );
// });
// });

it('simulate debt share data', async () => {
const { mothership, satellite1, satellite2 } = chains;
Expand Down

0 comments on commit d03a0ed

Please sign in to comment.