-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarketUpdated event #1697
Merged
Merged
MarketUpdated event #1697
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
370fc2b
Add tracking code to runtime
0xjocke 38edefe
Add market size and market skew to
0xjocke a010484
Update test asserting the event
0xjocke 4350e84
Add MarketUpdated event.
0xjocke ee5f02a
We now hit a size limit AsyncOrderModule
0xjocke 0282bcd
Dont forget to update cannon files
0xjocke 4f6529f
Add currentFundingRate and currentFundingVelocity to MarketUpdated event
0xjocke e80afec
Revert IAsyncOrderViewModule
0xjocke c77e2f6
Use AsyncOrderSettlementModule like spot market
0xjocke 0f26123
Let call site emit MarketUpdated event to avoid emitting events from …
0xjocke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
markets/perps-market/contracts/interfaces/IAsyncOrderSettlementModule.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
//SPDX-License-Identifier: MIT | ||
pragma solidity >=0.8.11 <0.9.0; | ||
import {SettlementStrategy} from "../storage/SettlementStrategy.sol"; | ||
|
||
interface IAsyncOrderSettlementModule { | ||
error SettlementStrategyNotFound(SettlementStrategy.Type strategyType); | ||
error OffchainLookup( | ||
address sender, | ||
string[] urls, | ||
bytes callData, | ||
bytes4 callbackFunction, | ||
bytes extraData | ||
); | ||
|
||
event OrderSettled( | ||
uint128 indexed marketId, | ||
uint128 indexed accountId, | ||
uint256 fillPrice, | ||
int256 accountPnlRealized, | ||
int128 newSize, | ||
uint256 collectedFees, | ||
uint256 settelementReward, | ||
bytes32 indexed trackingCode, | ||
address settler | ||
); | ||
|
||
// only used due to stack too deep during settlement | ||
struct SettleOrderRuntime { | ||
uint128 marketId; | ||
uint128 accountId; | ||
int128 newPositionSize; | ||
int256 pnl; | ||
uint256 pnlUint; | ||
uint256 amountToDeposit; | ||
uint256 settlementReward; | ||
bytes32 trackingCode; | ||
} | ||
|
||
function settle(uint128 marketId, uint128 accountId) external view; | ||
|
||
function settlePythOrder(bytes calldata result, bytes calldata extraData) external payable; | ||
} |
13 changes: 13 additions & 0 deletions
13
markets/perps-market/contracts/interfaces/IMarketEvents.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
//SPDX-License-Identifier: MIT | ||
pragma solidity >=0.8.11 <0.9.0; | ||
|
||
interface IMarketEvents { | ||
event MarketUpdated( | ||
uint128 marketId, | ||
int256 skew, | ||
uint256 size, | ||
int256 sizeDelta, | ||
int256 currentFundingRate, | ||
int256 currentFundingVelocity | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any others around that we can throw in here maybe? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most modules will have their events defined in their own interface. I had a look, didn't see any clear ones to move