Fill price js impl #1698
Merged
Fill price js impl #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It feels wrong to do this, but having a bunch of hardcoded values also feels wrong...
Codecov Report
@@ Coverage Diff @@
## main #1698 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 57 57
Lines 720 720
Branches 236 236
=======================================
Hits 524 524
Misses 167 167
Partials 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Agree we shouldn't use hardcoded values. Ideally, we should add a test for the test helper. It can be done with plain numbers, but the helper will be useful on plenty of other tests where we have a derived number (fillPrice, fees, pnl, etc.) |
leomassazza
approved these changes
Jun 30, 2023
sunnyvempati
reviewed
Jul 4, 2023
0xjocke
force-pushed
the
settle-event-improvement
branch
from
853fe55
to
0f26123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a convo with david about how hard it is to debug tests with a bunch of hardcoded numbers..
And then I saw a TODO about fill price, so went ahead an implemented it.
Do we want to use it in the fillPrice tests? It does feel a little wrong to me... Should I create a spreadsheet?