Docs - some interfaces #1702
Merged
Docs - some interfaces #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1702 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 57 57
Lines 720 720
Branches 236 236
=======================================
Hits 524 524
Misses 167 167
Partials 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0xjocke
reviewed
Jul 4, 2023
| * @notice Gets the max market value of a market. | ||
| * @param marketId id of the market. | ||
| * @return maxMarketValue the max market value. | ||
| */ | ||
| function getMaxMarketValue(uint128 marketId) external view returns (uint256 maxMarketValue); |
There was a problem hiding this comment.
Maybe mention:
Max Market Value controls the maximum open interest a market an have on either side (Long | Short). So the total Open Interest for a market is Max Market Value * 2. This value is not defined in USD but in the native asset
0xjocke
reviewed
Jul 4, 2023
markets/perps-market/contracts/interfaces/IAsyncOrderModule.sol
Outdated
Show resolved
Hide resolved
0xjocke
approved these changes
Jul 4, 2023
|
Merge in my changes and fixed conflicts :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.