Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean lint warnings #1712

Merged
merged 9 commits into from
Jul 17, 2023
Merged

Clean lint warnings #1712

merged 9 commits into from
Jul 17, 2023

Conversation

leomassazza
Copy link
Contributor

@leomassazza leomassazza commented Jul 7, 2023

reduce the lint number of warnings from 30 to 7. The remaining 7 are in proxy.sol contracts that cannot be changed (even change comments).

@leomassazza leomassazza self-assigned this Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1712 (7ee5d20) into main (0679c45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1712   +/-   ##
=======================================
  Coverage   72.77%   72.77%           
=======================================
  Files          57       57           
  Lines         720      720           
  Branches      236      236           
=======================================
  Hits          524      524           
  Misses        167      167           
  Partials       29       29           
Flag Coverage Δ
core-contracts 93.26% <ø> (ø)
core-modules 90.47% <ø> (ø)
core-utils 68.57% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@leomassazza leomassazza marked this pull request as draft July 8, 2023 03:30
@leomassazza leomassazza marked this pull request as ready for review July 11, 2023 14:06
Copy link
Contributor

@sunnyvempati sunnyvempati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏽

@leomassazza leomassazza enabled auto-merge (squash) July 17, 2023 14:53
@leomassazza leomassazza merged commit 7e7143f into main Jul 17, 2023
19 checks passed
@leomassazza leomassazza deleted the clean-lint-warnings branch July 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants