SIP-335 allow approve amount 0 to revoke erc20 #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1742 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 57 57
Lines 720 720
Branches 236 236
=======================================
Hits 524 524
Misses 167 167
Partials 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sunnyvempati
approved these changes
Aug 8, 2023
| @@ -175,6 +175,12 @@ contract ERC20 is IERC20 { | |||
| } | |||
| } | |||
|
|
|||
| function _checkZeroAddress(address target) private pure { | |||
There was a problem hiding this comment.
maybe reuse this by calling this function in _checkZeroAddressOrAmount. nonblocking
| @@ -221,6 +217,20 @@ describe('ERC20', function () { | |||
| assertBn.equal(evt.args.amount, approvalAmount); | |||
| }); | |||
|
|
|||
| describe('approve()', async function () { | |||
There was a problem hiding this comment.
assuming there's already a test for zero address?
sunnyvempati
approved these changes
Aug 16, 2023
noahlitvin
added a commit
that referenced
this pull request
Aug 30, 2023
* feat: SIP-326, additional pool configuration * fix: linting issue * fix: resolve PR comments * add ability to specify pool collateral configuration in particular, the ability to limit the amounto f collateral thats deposited to a pool * ability to pass runtime values into oracle manager nodes they can be passed as an array of keys and values. a simple loop looking over all the keys can find any necessary . an example of how this could be used is for an external node to check to see what the volume of a particular order is, to modify the oracle's resulting value based on the calculation. * lint fix * feat: add pool collateral configuration * feat: update pool collateral configuration * fix: liniting * fixes for audit * fix typo in external node definition * emit parameter error when bytes32 arrays dont match up * fix: failing tests * SIP-332 (#1743) * started sip-332 * updated IssueUSDModule * fixing tests * defined var * fixed all tests * removed comment * fixing tests * removing unused constant * building repo * fixing test * removed only * ran build in the root --------- Co-authored-by: butternutsquash <[email protected]> * update storage * feat: update function name * feat: update mock external node * fix: linting issue * adding tests * update tests * Q-1 Macro * Q-3 Macro * Q-8 Macro * I-1 Macro * Spotmarket I-1 Macro * M-3 removing payable * SIP-335 allow approve amount 0 to revoke erc20 (#1742) * SIP-335 allow approve amount 0 to revoke erc20 * Reuse _checkZeroAddress in _checkZeroAddressOrAmount Addressed comments in PR #1742. --------- Co-authored-by: Sunny Vempati <[email protected]> * Sip-323 (#1729) * feat: upgrade token in AssociatedSystemsModule * fix test assert * fix: perps graph issue * feat: update core subgraph core proxy * leave symbol for now --------- Co-authored-by: Noah Litvin <[email protected]> Co-authored-by: Matías <[email protected]> Co-authored-by: Matías Lescano <[email protected]> Co-authored-by: Noisekit <[email protected]> * SIP-331 Add getMarketAddress view to the MarketManagerModule (#1703) * Add getMarketAddress view to the MarketManagerModule * Regenerate docs * docs --------- Co-authored-by: Noah Litvin <[email protected]> * docgen * fixed tests * added L-2 Macro * fix linting * fixing test * fixing test * added test case * merged main and gen contracts docs * remove only * Sip-332: update pool collateral configuration logic (#1776) * feat: update pool collateral configuration logic * feat: update pool configuration module * remove multicallThrough * increase spot market factory test coverage * added test case * removed precision check * fix: update pool tests * lint fix * fix: storage issue * feat: rename maxDepositD18 to collateralLimitD18 * fix: revert in decreaseAvailableCollateral * chore: remove redundant code in spot market * fix: issuanceRatioD18 and liquidationRatioD18 validation * chore: update error name * feat: set depositing enabled for USD --------- Co-authored-by: Daniel Beal <[email protected]> Co-authored-by: Noah Litvin <[email protected]> Co-authored-by: max <[email protected]> Co-authored-by: butternutsquash <[email protected]> Co-authored-by: max <[email protected]> Co-authored-by: David Vuong <[email protected]> Co-authored-by: Sunny Vempati <[email protected]> Co-authored-by: Matías <[email protected]> Co-authored-by: Matías Lescano <[email protected]> Co-authored-by: Noisekit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://sips.synthetix.io/sips/sip-335/