-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 CI fix hardhat not loading solc on Node18 #1760
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1760 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 57 57
Lines 720 720
Branches 236 236
=======================================
Hits 524 524
Misses 167 167
Partials 29 29
*This pull request uses carry forward flags. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's time we update to node 18 anyway. Maybe node 20 while we are at it
Node 20 LTS will start on 2023-10-24, so 18 is the way for now |
563a1de
to
f878771
Compare
f878771
to
1d54a86
Compare
This probably needs hardhat upgrade because on node 18 tests are randomly getting stuck forever for no apparent reason. |
Update Node version to avoid hardhat silently bail with success
For context:
Hardhat randomly just silently quitting with exit code 0 when downloading solc compiler
It was an issue with NodeJS in some versions and looks like 18.16.0 is one of the affected versions (see NomicFoundation/hardhat#3877)
Using fresher (or older version of node solves it).
on
18.17.1
couple of the core-utils tests are failing, so sticking to18.15.0
for now.