Run only tests for PRs and run coverage report on main #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1762 +/- ##
===========================================
- Coverage 72.77% 56.88% -15.89%
===========================================
Files 57 96 +39
Lines 720 1299 +579
Branches 236 451 +215
===========================================
+ Hits 524 739 +215
- Misses 167 521 +354
- Partials 29 39 +10
see 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbeal-eth
approved these changes
Aug 11, 2023
| "@synthetixio/hardhat-storage", | ||
| "@synthetixio/sample-project", | ||
|
|
||
| # "@synthetixio/legacy-market", # tests fail |
There was a problem hiding this comment.
Tests shouldn't fail, what can I say. The tests were refreshed just a couple weeks ago.
There was a problem hiding this comment.
Let's enable them when tests are not failing
Getting bunch of errors like these:
Also legacy market was not tested in CI before
noisekit
force-pushed
the
coverage
branch
3 times, most recently
from
f897fe1
to
bf6c805
Compare
…ble) on main branch only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we run coverage report on each commit we never actually submit those reports to Codecov
@dbeal-eth suggested not to run cov report on PRs. That makes sense as
maintakes like 15min to do cov report (because running on hardhat net is slow!)Because of that now we only run tests on PRs (must be pretty quick) and coverage report (which also includes all the tests) will only run on main branch
This should speed up day to day dev a lot buy running tests much much faster in CI