loosen restrictions on clip names #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nikodemus
commented
Dec 10, 2024
nikodemus
commented
- Allow multiple clips to share a name as long as they're all on different outputs.
- Allow multiple clips to share a name as long as they're all on different outputs.
seangoodvibes
approved these changes
Dec 10, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Dec 10, 2024
eef5a49
6 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
- Allow multiple clips to share a name as long as they're all on different outputs.
nikodemus
added a commit
to nikodemus/DelugeFirmware
that referenced
this pull request
Dec 11, 2024
- Allow multiple clips to share a name as long as they're all on different outputs. From SynthstromAudible#3046 - move Song::getClipFromName() to Output, so that we actually check the right thing -- previously if tracks 1 & 2 both have a clip named A, the check might find the clip from track 2, allowing a duplicate name on track 1. From SynthstromAudible#3056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.