Fix bug with display for kit automation overview #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the automation overview for kits when affect entire is disabled and no drum is selected the display would show "Select Affect Entire / Drum" even pressing affect entire. it was happening because affect entire state was being changed after the display had already refreshed moving the display refresh after the affect entire state is changed fixes this
stellar-aria
approved these changes
Dec 11, 2024
Merged
via the queue into
SynthstromAudible:community
with commit Dec 11, 2024
6eab902
6 checks passed
github-actions bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
There was a bug in the automation overview for kits when affect entire is disabled and no drum is selected the display would show "Select Affect Entire / Drum" even pressing affect entire. it was happening because affect entire state was being changed after the display had already refreshed moving the display refresh after the affect entire state is changed fixes this
seangoodvibes
deleted the
Fix-bug-with-display-for-Kit-Automation-Overview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the automation overview for kits when affect entire is disabled and no drum is selected
the display would show "Select Affect Entire / Drum" even after pressing affect entire.
it was happening because the affect entire state was being changed after the display had already refreshed
moving the display refresh after the affect entire state is changed fixes this