horizontal menus for LPF and HPF #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikodemus
force-pushed
the
pr-horizontal-menus-for-filters
branch
9 times, most recently
from
151cf7a to
d46a5de
Compare
- Add support for displaying Selection-instances in horizontal menus, in order to display current filter mode. This uses regular font size to fit in 4 character names. - Move renderInHorizontalMenu() from patched_param::Integer to Number, where it works for both patched and unpatched parameters. - Refactor the colummn label code to MenuItem::renderColumnLabel(), fixing a bug in the chop-to-width logic while at it. - Refactor classes used for filter params to be more generic, so we don't need so many of them. - Fix a bug in horizontal menu rendering when there's only one relevant item, which isn't the first item. - Filter modes get short names (12DB, 24DB, DRV, BP, NTCH) to fit into a mode-column. - Remove the special casing for filter freq display on 7-seg: it no longer display as OFF when fully open without modulation. - Re-order the filter menu so mode is last, which works better in the horizontal menu -- and arguably in the vertical as well, even if there's now a slight ordering mismatch betweeh shortcuts and the menu. - Morph column is titled by the morph name for the filter family. - Rename the NONE filter mode to OFF, which seems clearer in the menu. - Turning filter mode to oFF makes all other filter menu items non-relevant.
nikodemus
force-pushed
the
pr-horizontal-menus-for-filters
branch
from
d46a5de to
bdc155f
Compare
nikodemus
changed the title
sapphire-arches
approved these changes
Jan 2, 2025
Merged
via the queue into
SynthstromAudible:community
with commit Jan 2, 2025
f07637a
6 checks passed
soymonitus
pushed a commit
to soymonitus/DelugeFirmware
that referenced
this pull request
Jan 2, 2025
- Add support for displaying Selection-instances in horizontal menus, in order to display current filter mode. This uses regular font size to fit in 4 character names. - Move renderInHorizontalMenu() from patched_param::Integer to Number, where it works for both patched and unpatched parameters. - Refactor the colummn label code to MenuItem::renderColumnLabel(), fixing a bug in the chop-to-width logic while at it. - Refactor classes used for filter params to be more generic, so we don't need so many of them. - Fix a bug in horizontal menu rendering when there's only one relevant item, which isn't the first item. - Filter modes get short names (12DB, 24DB, DRV, BP, NTCH) to fit into a mode-column. - Remove the special casing for filter freq display on 7-seg: it no longer display as OFF when fully open without modulation. - Re-order the filter menu so mode is last, which works better in the horizontal menu -- and arguably in the vertical as well, even if there's now a slight ordering mismatch betweeh shortcuts and the menu. - Morph column is titled by the morph name for the filter family. - Rename the NONE filter mode to OFF, which seems clearer in the menu. - Turning filter mode to oFF makes all other filter menu items non-relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
menus, in order to display current filter mode. This uses
regular font size to fit in 4 character names.
Number, where it works for both patched and unpatched parameters.
fixing a bug in the chop-to-width logic while at it.
so we don't need so many of them.
relevant item, which isn't the first item.
fit into a mode-column.
no longer display as OFF when fully open without modulation.
in the horizontal menu -- and arguably in the vertical as well,
even if there's now a slight ordering mismatch betweeh shortcuts
and the menu.
menu.
non-relevant.