Skip to content

FixedPoint/Intrinsics improvements.#3527

Merged
stellar-aria merged 6 commits intocommunityfrom
fixedpoint-improvements
Mar 29, 2025
Merged

FixedPoint/Intrinsics improvements.#3527
stellar-aria merged 6 commits intocommunityfrom
fixedpoint-improvements

Conversation

@stellar-aria
Copy link
Copy Markdown
Collaborator

@stellar-aria stellar-aria commented Mar 29, 2025

Originally part of #3519, separated here for ease of review, I'll rebase once this is merged.

Summary:

  • General FixedPoint class improvements
  • Unification of ARMv7 intrinsics with portable code.
  • Separation of intrinsics from fixedpoint.h
  • Re-target current Q31 macros onto FixedPoint in preparation for eventual migration
  • Swap asm clz out with std::countl_zero. These are instruction-identical (see godbolt link in docstring)
  • Remove inline asm for SSAT for equivalent std::clamp (see godbolt link)

@stellar-aria stellar-aria self-assigned this Mar 29, 2025
@stellar-aria stellar-aria added the refactor Refactoring (but not necessarily functional change) of codebase label Mar 29, 2025
@stellar-aria stellar-aria requested a review from m-m-adams March 29, 2025 17:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 29, 2025

Test Results

111 tests  ±0   111 ✅ ±0   1s ⏱️ ±0s
 17 suites ±0     0 💤 ±0 
 17 files   ±0     0 ❌ ±0 

Results for commit b6eb627. ± Comparison against base commit ae2d9ff.

♻️ This comment has been updated with latest results.

@stellar-aria stellar-aria force-pushed the fixedpoint-improvements branch from a010c8e to 5880012 Compare March 29, 2025 17:16
@stellar-aria stellar-aria force-pushed the fixedpoint-improvements branch from 7840905 to 53e6d8e Compare March 29, 2025 17:26
@stellar-aria stellar-aria added this pull request to the merge queue Mar 29, 2025
Merged via the queue into community with commit 3412620 Mar 29, 2025
8 checks passed
@stellar-aria stellar-aria deleted the fixedpoint-improvements branch April 11, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring (but not necessarily functional change) of codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants