Skip to content

Fix poly aftertouch#3559

Merged
seangoodvibes merged 1 commit intoSynthstromAudible:communityfrom
m-m-adams:bugfix/poly_aftertouch
Apr 6, 2025
Merged

Fix poly aftertouch#3559
seangoodvibes merged 1 commit intoSynthstromAudible:communityfrom
m-m-adams:bugfix/poly_aftertouch

Conversation

@m-m-adams
Copy link
Copy Markdown
Collaborator

@m-m-adams m-m-adams commented Apr 6, 2025

Poly aftertouch output stopped working as the arp now needs the output member channel to be set before sending note expression, and it wasn't for non-mpe notes.

Fix it to always give arp note the correct channel even if not an MPE output

@m-m-adams m-m-adams added bug cherry-pick Commit to cherry pick to release branch labels Apr 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2025

Test Results

111 tests  ±0   111 ✅ ±0   1s ⏱️ ±0s
 17 suites ±0     0 💤 ±0 
 17 files   ±0     0 ❌ ±0 

Results for commit 60e71a9. ± Comparison against base commit b92b216.

@seangoodvibes seangoodvibes added this pull request to the merge queue Apr 6, 2025
Merged via the queue into SynthstromAudible:community with commit a805ec3 Apr 6, 2025
8 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 6, 2025
@m-m-adams @web-flow
always give arp note a channel if midi or cv (#3559)
882ec5f
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 24, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
baa8fa2
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
ff0f7d4
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
1e1026c
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
f682319
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
05259aa
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
5029bca
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
27114bf
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
c9d066e
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
7370281
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
d17c5ba
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 25, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
8fb936f
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
8313b1c
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
7216834
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
477702f
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
9d6d17d
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
438a7a8
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
cdedc6e
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
0134a53
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
be12409
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
6c4f7c4
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
0bdae04
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
6d7c052
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
c30605f
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
91fa88f
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
55dec12
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
58ec8ce
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
a7acad2
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
00bea3e
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
6b515c2
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
a02d409
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
9046a58
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
2a4c766
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
27c67e1
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
35e06fb
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
f1fd285
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
2bf7d1d
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
da2d8d2
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
28f01cc
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
abf16e0
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
c8e975b
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
e5bdef2
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
4e76ec3
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
4ce7a06
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
6ee0a00
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
4a0da7c
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
472f4a0
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
131c756
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
8578859
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
16a6ad6
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
b8a1e52
seangoodvibes pushed a commit to seangoodvibes/DelugeFirmware that referenced this pull request Jan 26, 2026
@m-m-adams @seangoodvibes
always give arp note a channel if midi or cv (SynthstromAudible#3559)
08a6780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seangoodvibes seangoodvibes seangoodvibes approved these changes

Assignees

No one assigned

Labels

cherry-pick Commit to cherry pick to release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@m-m-adams @seangoodvibes