feat: added native Firefox support and dual-browser build process#2
feat: added native Firefox support and dual-browser build process#2AnkanMisra wants to merge 3 commits into
Conversation
Add Firefox support and dual browser build
📝 WalkthroughWalkthroughThe extension is being extended to support both Chrome and Firefox browsers. Firefox-specific manifest settings are added, the build process is refactored to generate separate platform-specific archives with platform-appropriate manifests, HTML link matching is improved with case-insensitive selector syntax, and documentation is updated with cross-browser guidance and publishing instructions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
15-19: Consider noting Firefox temporary add-on lifecycle.Optional: add one sentence that “Load Temporary Add-on” is cleared on Firefox restart, so local reloading is expected.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 15 - 19, Add a brief note to the Firefox instructions stating that "Load Temporary Add-on" is cleared on Firefox restart so the temporary extension must be reloaded after restarting the browser; update the Firefox section (the steps referencing about:debugging#/runtime/this-firefox and selecting manifest.json) to include this single-sentence lifecycle note so users know local reloading is expected.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Around line 15-19: Add a brief note to the Firefox instructions stating that
"Load Temporary Add-on" is cleared on Firefox restart so the temporary extension
must be reloaded after restarting the browser; update the Firefox section (the
steps referencing about:debugging#/runtime/this-firefox and selecting
manifest.json) to include this single-sentence lifecycle note so users know
local reloading is expected.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6c3ebb1b-4da9-416b-9fff-a0febbcfb53b
📒 Files selected for processing (4)
README.mdcontent.jsmanifest.jsonscripts/build.sh
This PR introduces native Firefox compatibility using the existing Manifest V3 codebase, alongside a refined build pipeline for multi store distribution
Key Changes
browser_specific_settings.geckoblock tomanifest.jsonfor Mozilla Add-on (AMO) distributionscripts/build.shto generate distinct-chromeand-firefoxrelease archives. The script dynamically strips the Gecko configuration from the Chrome manifest before zipping, ensuring a clean, warning-free package for the Chrome Web Storecontent.jsto use the CSS case-insensitive flag (a[href^="mailto:" i]), ensuring mixed-case links (e.g.,Mailto:) are reliably interceptedREADME.mdto match the existing Chrome documentation formatSummary by CodeRabbit
New Features
Bug Fixes
Documentation