Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-519: APCD Custom getting started page #281

Merged
merged 2 commits into from
Mar 27, 2024
Merged

WP-519: APCD Custom getting started page #281

merged 2 commits into from
Mar 27, 2024

Conversation

chandra-tacc
Copy link
Contributor

Overview

Getting started for APCD needs to be same link for all 3 environments. Since this page is being modified for other areas, just add a custom template.

Related

Changes

  1. add a new template
  2. deployment config is modified: https://github.com/TACC/Core-Portal-Deployments/blob/main/apcd/camino/cms.settings_custom.py#L23

Testing

  1. Go to https://dev.apcd.tacc.utexas.edu/help/getting-started/
  2. Click the signup for a new account link
  3. It should be pointing to non-dev url

@wesleyboar wesleyboar mentioned this pull request Mar 27, 2024
Merged
wesleyboar
wesleyboar reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you put the template instead in /apcd-cms/src/taccsite_cms/templates/guides/, then there is no need to update the settings and also the template path will remain standard and compatible. See #282 for change and more explanation.

@wesleyboar
WP-519: APCD Custom getting started page - more standard & compatible (…
abaaea7 
…#282)

* refactor: WP-519 move html so no setting change

If the tempalte is at thsi directory, no settings change is required.

* test: WP-519 different content

* Revert "test: WP-519 different content"

This reverts commit 548fe66.

* feat: WP-519 different content
@chandra-tacc
Copy link
Contributor Author

If you put the template instead in /apcd-cms/src/taccsite_cms/templates/guides/, then there is no need to update the settings and also the template path will remain standard and compatible. See #282 for change and more explanation.

Thanks @wesleyboar - I took your changes and tested it on dev.apcd. It works.

@chandra-tacc chandra-tacc merged commit 00b610b into main Mar 27, 2024
@chandra-tacc chandra-tacc deleted the task/WP-519 branch March 27, 2024 20:36
@wesleyboar wesleyboar mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandra-tacc @wesleyboar