feat(apcd-cms): new table & modal ui (from core-styles) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
force-pushed
the
task/fp-1878-tup-354-table-and-modal
branch
from
2637886
to
d38a991
Compare
BREAKING CHNAGE: Modal UI looks bad, because it has not been styled in CMS. It just uses styles copied from Portal.
wesleyboar
force-pushed
the
task/fp-1878-tup-354-table-and-modal
branch
from
d38a991
to
4376d82
Compare
The classes must not yet be included in site.css from core-styles... Warning: These classes are not loading yet.
|
Closed in favor of #159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
.o-table-wrapin itssite.css.Overview
Add table styles and modal styles from TACC/Core-Styles via new TACC/Core-CMS image.
Related
Changes
Testing
UI
…