feat(core-styles): v2 #569

wesleyboar · 2022-11-16T03:51:33Z

Overview

Use Core-Styles v2 via new setting, for future-compatibility.
Use Core-Styles v0 by default, for backwards-compatibility.
Freeze CMS v3.10.1 CMS stylesheets as site.___.css.

This solution avoids a CMS v4 right now. CMS upgrades would be more likely neglected if migration was required. (Even v3 CMS's upgrades had been neglected.) When 4.0.0 does come (to remove `TACC_CORE_STYLES_VERSION` setting), any CMS's not already upgraded to Core-Styles v2 obviously did not deserve the attention, and are allowed to remain stuck.

Changes

Core CMS

changed core-styles dependency from v0 to v2
added TACC_CORE_STYLES_VERSION setting
^{(so each cms can decide when it is ready to use newer core-styles)}
added placeholder CDN stylesheets for core-styles bundles
^{(not using https://unpkg.com cuz I worry that depending on an external service for primary stylesheets)}
added templates that load Core-Styles v2 the way it is designed to be loaded
changed some stylesheets based on what now comes from Core-Styles
changed site.___.css stylesheets to be minified versions of what they were in v3.10.1
changed include of templates to be conditional based on TACC_CORE_STYLES_VERSION
changed loading of assets to be conditional based on TACC_CORE_STYLES_VERSION
changed demo to use new Core Styles v2 demo API
and more

Core Styles

feat!: ease use of core-styles Core-Styles#81
fix(demo)!: font path change in dist Core-Styles#73
feat!: provide CDN-style deliverable stylesheets Core-Styles#78
so much added, fixed, changed: https://github.com/TACC/Core-Styles/releases/tag/v2.0.0
contextual accent colors: https://github.com/TACC/Core-Styles/releases/tag/v2.1.0
so much added, fixed, changed: TACC/Core-Styles@v2.1.0...v2.8.0
changed colors & typography
feat: change accent color from purple to blue Core-Styles#149
chore: retire env()-based themes (Core-CMS v3.10) Core-Styles#163
and more

Testing & UI

Future Compatibility

TUP launch via dev/tup-cms branch*: feat(tup-cms): accent colors & new ui patterns & ui demo fixes tup-ui#67
^{(this used an older commit of task/get-core-styles-beyond-0.11.0)}
TUP upgrade to use new CMS release: feat(tup-cms): core-cms v3.12.0-alpha tup-ui#232

Backwards Compatibility

TACC/Core-Styles#69

The previously installed branch was merged to main.

- fix(fonts): fp-1891 add regular italic, also add black (#71) - feat(objects): warning about still-disabled o-site - feat(components): icon updates from Core-Portal - docs(trumps): comment about lifespan of u-empty - chore(elements): body margin 0 - feat(dist): commit dist for clients relying on it (#70) - chore: import dependencies in each pattern

In Core-Styles, icon CSS moved: trumps/icon → components cortal.icon.

J.R. and I agree a real CDN makes sense for Core-Styles, long-term. J.R. doesn't know about this temp solution yet. He'll have better idea.

No need to re-build Core-Styles since we have it's `dist/`. Related PR: TACC/Core-Styles#70

- Add core styles version setting. - Load core-styles from pseudo-CDN. - Use new CSS layer tech to load stylesheets.

wesleyboar

Round 1 Review Comments

package.json

wesleyboar · 2023-05-26T04:00:30Z

taccsite_cms/settings.py

+########################
+# TACC: CORE STYLES
+########################
+
+# Only use integer numbers (not "v1", not "0.11.0"),
+# so templates can load based on simple comparisons
+TACC_CORE_STYLES_VERSION = 0
+


added TACC_CORE_STYLES_VERSION setting
^{(so each cms can decide when it is ready to use newer core-styles)}

Eventually, will we be able to drop the if blocks for the version check, once all the portals are migrated forward? Or do you want to keep this setting to future-proof v3 development.

If retained, is the v1/v2 filename nomenclature the presence of the site. prefix in the v1 filenames (eg. 'site_cms/css/build/site.app.blog.css' vs 'site_cms/css/build/app.blog.css')?

Uncertain, the future of this setting is.

I want to remove it after migration, but we may be slow to migrate. Proof: CMD still has CMS v1 (pre Core-Styles) CSS like A2CPS and Frontera.

Yes, the site. prefix distinguishes CMS styles that use Core-Styles v0.

I do not like this, because it is not obvious. I think these site.____.css stylesheets belong in https://github.com/TACC/Core-CMS/tree/main/taccsite_cms/static/site_cms/css/src/_migrations. But Core-Portal and Frontera Tech Docs expect the filenames site.header.css and site.tacc-search-bar.css, and I have been too lazy to work in those repos again.

taccsite_cms/settings.py

wesleyboar

Round 2 Review Comments

taccsite_cms/static/site_cms/css/.postcssrc.yml

bin/build-css.js

taccsite_cms/contrib/taccsite_system_specs/templates/system_specs.html

taccsite_cms/static/site_cms/css/src/_core-styles/core-styles.base.css

taccsite_cms/static/site_cms/css/src/_imports/components/c-button.css

taccsite_cms/templates/style_guide.html

taccsite_ui/fractal.config.js

taccsite_ui/fractal.theme.js

taccsite_ui/patterns/core-cms

taccsite_ui/patterns/core-styles

taccsite_cms/settings.py

taccsite_cms/templates/assets_site.html

taccsite_ui/fractal.config.js

taoteg

Had a few inquiries and minor comments, but LGTM!

wesleyboar

Peer Review Feedback

Move site.___.css into _migrations.
^{feat(core-styles): v2 - move v3.10 stylesheets to _migration #656}
(after merge) Ask CMD whether the conversion of a CMS-side can be tasked to an intern.
^{I asked CMD privately; H.P. answers affrimatively.}
(after merge) Provide an architectural illustration.
^{I will do this better, later, to more people. I can reference Shared UI - CSS - Architecture.}
(after merge) Determine how to make the CSS less daunting.
^{This is a constant effort. After feat(core-styles): v2 - move v3.10 stylesheets to _migration #656, this PR will represent an improvement.}

https://github.com/TACC/Core-Styles/releases/tag/v2.9.0

wesleyboar · 2023-06-12T23:52:19Z

I moved the site.___.css to _migrations/v3-10_v3-11 via recently-merged #656.

@tacc/core-styles v2+ does not limit input field length. But APCD relies on it (the limit was built for APCD's first form.) This commit need not be in main until APCD loads Core-CMS post #569. TACC/Core-CMS#569

wesleyboar added 3 commits November 15, 2022 21:40

feat(core-styles): get updates beyond v0.11.0

5f39df6

fix(core-styles): import new table objects

10cac65

fix(core-styles): rename file so a demo page loads

e4bea96

TACC/Core-Styles#69

This was referenced Nov 16, 2022

feat(objects): o-table, o-fixed-header-table, o-flex-item-table-wrap TACC/Core-Styles#68

Merged

fix(o-table-wrap): …scroll.extra → …scroll-extra TACC/Core-Styles#69

Merged

wesleyboar and others added 5 commits November 16, 2022 10:46

feat(taccsite_ui): use tup cms link color

2cb3611

fix(core-styles): let demo bootstrap, fix caption

87b8df3

Merge branch 'main' into task/get-core-styles-beyond-0.11.0

081ab3b

feat(core-styles): pin to latest of main now

d8fd7bc

The previously installed branch was merged to main.

Merge branch 'main' into task/get-core-styles-beyond-0.11.0

9d1597b

wesleyboar mentioned this pull request Nov 17, 2022

feat(tup-cms): accent colors & new ui patterns & ui demo fixes TACC/tup-ui#67

Merged

wesleyboar marked this pull request as ready for review November 17, 2022 15:50

wesleyboar added 18 commits November 21, 2022 15:02

feat(core-styles): install base stylesheets

79c60d1

fix(core-styles): install fixed base stylesheets

7eb8d98

chore(npm): copy fonts after css build (specific)

ff12358

fix(core-styles): load icons (which moved)

68d8a21

In Core-Styles, icon CSS moved: trumps/icon → components cortal.icon.

feat(css): serve core-styles base CSS as if a CDN

34b87df

J.R. and I agree a real CDN makes sense for Core-Styles, long-term. J.R. doesn't know about this temp solution yet. He'll have better idea.

chore(taccsite_ui): no re-build core-styles dist

1daff5d

No need to re-build Core-Styles since we have it's `dist/`. Related PR: TACC/Core-Styles#70

fix(core-styles): base.*.css → core-styles.*.css

7872ca5

test(css): v1 core-styles: setting, layers

3d5f11c

- Add core styles version setting. - Load core-styles from pseudo-CDN. - Use new CSS layer tech to load stylesheets.

Merge branch 'main' into task/get-core-styles-beyond-0.11.0

5dc6fea

fix(css): v1 core-styles: export setting

ee79fad

chore(settings): explicit pass to templates

3179f3a

fix(settings): TACC_CORE_STYLES_VERSION nav_search

03fb16c

fix(core-styles): base includes cms

be4d68a

fix(core-styles): load latest (i thought i had)

09ead26

fix(core-styles): s-portal-nav on layers

9757a07

fix(core-styles): build s-portal-nav on layers

4f88465

feat(css): project.global.css, if/then font load

86c8213

wesleyboar commented May 26, 2023

View reviewed changes

docs(templates): word a comment better

61d8261

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into task/get-core-styles-beyond-0.11.0

7b1288a

wesleyboar marked this pull request as ready for review May 26, 2023 16:50

wesleyboar changed the title ~~feat(core-styles): v2 ⚠️~~ feat(core-styles): v2 ❤️ May 26, 2023

wesleyboar changed the title ~~feat(core-styles): v2 ❤️~~ feat(core-styles): v2 ❗️ May 26, 2023

wesleyboar changed the title ~~feat(core-styles): v2 ❗️~~ feat(core-styles): v2 May 26, 2023

wesleyboar commented May 26, 2023

View reviewed changes

wesleyboar requested review from taoteg, rstijerina and edmondsgarrett May 26, 2023 18:12

taoteg reviewed May 26, 2023

View reviewed changes

taccsite_cms/settings.py Outdated Show resolved Hide resolved

taoteg reviewed May 26, 2023

View reviewed changes

taccsite_cms/templates/assets_site.html Outdated Show resolved Hide resolved

taoteg reviewed May 26, 2023

View reviewed changes

taccsite_ui/fractal.config.js Outdated Show resolved Hide resolved

taoteg approved these changes May 26, 2023

View reviewed changes

wesleyboar mentioned this pull request May 26, 2023

feat(tup-cms): core-cms v3.12.0-alpha TACC/tup-ui#232

Merged

4 tasks

wesleyboar commented May 31, 2023

View reviewed changes

wesleyboar added 2 commits June 9, 2023 10:22

Merge branch 'main' into task/get-core-styles-beyond-0.11.0

5d05236

Merge branch 'main' into task/get-core-styles-beyond-0.11.0

04cd7f3

wesleyboar mentioned this pull request Jun 12, 2023

feat(core-styles): v2 - move v3.10 stylesheets to _migration #656

Merged

1 task

wesleyboar and others added 3 commits June 12, 2023 18:11

chore: core-styles v2.9.0

2c4507e

https://github.com/TACC/Core-Styles/releases/tag/v2.9.0

feat(core-styles): v2 - move v3.10 stylesheets to _migration (#656)

ccd3b6d

docs: comment improvments, typo fixes, removals

08815cf

wesleyboar merged commit 5e32c8a into main Jun 12, 2023

wesleyboar deleted the task/get-core-styles-beyond-0.11.0 branch June 12, 2023 23:52

wesleyboar restored the task/get-core-styles-beyond-0.11.0 branch June 12, 2023 23:54

wesleyboar deleted the task/get-core-styles-beyond-0.11.0 branch November 13, 2023 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core-styles): v2 #569

feat(core-styles): v2 #569

wesleyboar commented Nov 16, 2022 •

edited

Loading

wesleyboar left a comment •

edited

Loading

wesleyboar May 26, 2023

taoteg May 26, 2023

wesleyboar May 31, 2023

This comment was marked as outdated.

wesleyboar left a comment •

edited

Loading

taoteg left a comment

wesleyboar left a comment •

edited

Loading

wesleyboar commented Jun 12, 2023

feat(core-styles): v2 #569

feat(core-styles): v2 #569

Conversation

wesleyboar commented Nov 16, 2022 • edited Loading

Overview

Related

Changes

Core CMS

Core Styles

Testing & UI

Future Compatibility

Backwards Compatibility

wesleyboar left a comment • edited Loading

Choose a reason for hiding this comment

wesleyboar May 26, 2023

Choose a reason for hiding this comment

taoteg May 26, 2023

Choose a reason for hiding this comment

wesleyboar May 31, 2023

Choose a reason for hiding this comment

This comment was marked as outdated.

wesleyboar left a comment • edited Loading

Choose a reason for hiding this comment

taoteg left a comment

Choose a reason for hiding this comment

wesleyboar left a comment • edited Loading

Choose a reason for hiding this comment

Peer Review Feedback

wesleyboar commented Jun 12, 2023

wesleyboar commented Nov 16, 2022 •

edited

Loading

wesleyboar left a comment •

edited

Loading

wesleyboar left a comment •

edited

Loading

wesleyboar left a comment •

edited

Loading