-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django to v3.2 #625
Conversation
Core-CMS Image: https://jenkins01.tacc.utexas.edu/job/Core_CMS_Build/1052/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After completing the rename of example-cms
to example_cms
1, I came across a follow-up problem. If we do this on main
, then every website must have its app name renamed from aaa-bbb
to aaa_bbb
. I say this because I got this error:
[...] django.core.exceptions.ImproperlyConfigured: The app label 'a2cps-cms' is not a valid Python identifier.
And I expect to get that error for every directory in https://github.com/TACC/Core-CMS-Resources. Renaming these also means renaming template paths2 for some websites, which means (upon re-deploy of those websites) re-assigning the template each page uses—a gotcha likely to be forgotten or neglected or ignored, causing failure and delay with deploy.
Due to the priority given to this task, I feel forced to propose this PR be built off of dev/tup-cms
instead of main
.
Footnotes
-
Because a dash is not a valid Python identifier, and now Django prevents such a name. ↩
-
Because template paths (used to load custom assets) include the app directory name.3 ↩
-
Because template overriding is not supported in Core-CMS-Resources.45 ↩
-
Because I created project customization without enough knowledge. ↩
-
An old, paused attempt to fix this is Bugfix/fp 1652 template load order #492. ↩
I'll be back to work on this, next week. |
Requires TACC/Core-CMS-Resources#176. Because fixing other sites will slow down TUP work, we've created #626. |
Just wanted to add that there appear to be some versioning mismatches here, in that DjangoCMS v3.7.4 only supports up to Django v3.0. Current versions:
Updates since:
|
I don't know about incompatible, but not fully supported for sure. I would expect there would be things that break, else they would have made the dependency jump in the CMS. Its probably a case-by-case basis on how well the compatibility maps, so may depend on what pieces of the CMS we are using in terms of seeing breakage. But it isn't officially supported so if stuff does break for us, that would be on us to deal with if we don't migrate to a newer version. Do we have any overt blockers if we jump to the front of the current releases line and use (aside from working through the version bumps on the dependencies that would entail... and of course Thoughts? |
@taoteg Okay, thanks. I bet that explains the admin UI bugs I found. Otherwise, the admin UI works, and the rendering has not changed. Yes. Jump delayed until TUP-454 because Jake found plugins that may not survive the jump. |
To Do
|
I've noticed many warnings, in TUP-CMS, which has this upgrade. I reported them to the source app generating the most: nephila/djangocms-blog#737. A solution could be in our control. The problem might be because of the incompatibility @taoteg found. Uncertain. |
I indirectly tested this on dev.cep successfully by deploying v3.12.0-alpha.1 (a.k.a. |
There are known admin UI bugs, likely because of mismatched patch versions of dependencies. But I expect the update to Django v4 to resolve that: |
@taoteg Regarding your concern about question, I think we jumped further along than you think. Our use of This PR (actually #581) took us from Django CMS 3.7.4 to 3.11.1 and from Django 2.2.27 to 3.2.18. And a new PR (#707) takes us from Django CMS 3.11.3 to 3.11.4 and from Django 3.2.19 to 4.2.5. My brain is thoroughly scrambled now. Please help. Does this resolve your concern? |
Sounds like we are going to land at DjangoCMS 3.11.4 --> Django 4.2.5 (LTS) when this is all merged in. This does resolve my concerns. Nice work! |
Credit all to @jarosenb for the hard work. I just read and test and note. |
Overview
Update Django to v3.2 and bump deprecated dependencies.
Related
Testing