Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CMS c-button--as-link has button padding #785

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 11, 2024

Overview

Update Core-Styles to remove padding from a c-button--as-link on CMS.

Related

Changes

  • changed core-styles version

Testing

  1. Install TACC/Core-Styles#298 into a CMS.
  2. Create/Edit a page.
  3. Add Text plugin instance with Source code for three types of buttons:
    <p><button class="c-button c-button--primary">Button</button></p>
    <p><button class="c-button c-button--as-link">Button as a Link</button></p>
    <p><a class="c-button c-button--primary" href="#">Link as a Button</a></p>
  4. Verify "Button" looks like a primary button using a <button>.
  5. Verify "Button as a Link" looks like a link using a <button>.
  6. Verify "Link as a Button" looks like a primary button using a <a>.

UI

Before After
before after

Before

before.mov

After

after.mov

@wesleyboar wesleyboar marked this pull request as ready for review January 11, 2024 22:29
@wesleyboar wesleyboar merged commit ea7b071 into main Jan 11, 2024
@wesleyboar wesleyboar deleted the fix/cms-button-as-a-link-has-button-padding branch January 11, 2024 22:29
wesleyboar added a commit that referenced this pull request Jan 11, 2024
The merge of #785 was premature. I should have released a new Core-Styles.

But I immediately released v2.23.1 which has identical code (besides version comment) to what was installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant