Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce CSS in Core-CMS #291

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 5, 2024

Overview

Reduce the amount of CSS in TACC/Core-CMS.1

Related

Changes

  • added c-button--cms.css (from TACC/Core-CMS)
  • renamed :--cms-edit-mode and :--cms-logged-in to :--django-cms-…
  • added elements/irregular-link (imported by TACC/Core-CMS)
  • added elements/mailto-link (imported by core-styles.cms)
  • changed --global-color-link-on-dark--normal to --global-color-accent--xxx-light (as it was in TACC/Core-CMS)
  • added @custom-media xx-narrow-… (from TACC/Core-CMS)
  • added s-drop-cap (from TACC/Core-CMS)

Testing

c-button--cms

  1. Start a TACC/Core-CMS using this branch of Core-Styles.
  2. Create a button on the CMS.
  3. Verify the button has c-button styles from core-styles.cms.css.

irregular-link

Skip. No Core-Styles v2 site uses irregular links.

mailto-link

  1. Start a TACC/Core-CMS using this branch of Core-Styles.
  2. Create a <a href="mailto:__REMOVE_THIS__@[email protected]" data-user="someone" data-domain="here.there"> link on the CMS.
  3. Verify e-mail address appears as [email protected] not [email protected].

s-drop-cap

Core-Styles

  1. Verify "Trumps (Utilities & Scopes)" has "S-Drop-Cap".
  2. Verify http://localhost:3000/components/detail/s-drop-cap looks like https://dev.tup.tacc.utexas.edu/static/ui/components/detail/s-drop-cap.html.

Core-CMS

  1. Start a TACC/Core-CMS using this branch of Core-Styles.
  2. Create a paragraph with a parent that has the s-drop-cap class.
  3. Verify first letter of paragraph is large and takes three lines.

UI

c-button--cms, mailto-link, s-drop-cap s-drop-cap
reduce css - test 1 3 4 reduce css - test 4

Footnotes

  1. End goal is to remove CSS pre-processing from TACC/Core-CMS.

@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Jan 5, 2024
@wesleyboar wesleyboar marked this pull request as ready for review January 5, 2024 23:55
@wesleyboar wesleyboar merged commit 0378bb9 into main Jan 5, 2024
@wesleyboar wesleyboar deleted the feat/reduce-css-in-tacc-core-cms branch January 5, 2024 23:55
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of existing feature minor A feature in backward-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant