Translation from CPN to numeric planning #154
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDDL currently doesn't include effects
Move changes from personal repo to project organization
HGinnerup
commented
Jun 17, 2024
There was a problem hiding this comment.
In particular, two things from this project may be generally useful for the main branch.
- Color-types are iterable, which works well for enum-types, but not for product-types. The function
getAllPossibleColors(ColorType type)may be useful for implementing the iteration on product-types. - Currently the PNML parser uses the graphical UI, and therefore cannot be called in a headless environment. Some
isHeadlesshave been added, which allows the PNML parser to be used in a headless enviroment.
Comment on lines
+68
to
+81
| public static ArrayList<ArrayList<Color>> getAllPossibleColors(ColorType type) { | ||
| if(type.isProductColorType()) { | ||
| ArrayList<Iterable<Color>> subtypes = new ArrayList<>() {{ | ||
| addAll(type.getProductColorTypes()); | ||
| }}; | ||
|
|
||
| return util.cartesian(subtypes); | ||
| } | ||
| else { | ||
| return util.cartesian(new ArrayList<Iterable<Color>>() {{ | ||
| add(type); | ||
| }}); | ||
| } | ||
| } |
There was a problem hiding this comment.
This may be useful to implement for tuple-colors in general.
Currently, color types are iterable, and you can iterable on each element of an enum-color, but iterating on a product-color yields no elements.
Producting every possible product-color is implemented seperately here as I tried not to alter too much existing code.
| @@ -36,7 +36,7 @@ public class TimedPlaceComponent extends Place { | |||
| private dk.aau.cs.model.tapn.TimedPlace place; | |||
| private final dk.aau.cs.model.tapn.event.TimedPlaceListener listener = timedPlaceListener(); | |||
There was a problem hiding this comment.
These isHeadless checks may be interesting to add to main, as they allow the frontend to be run in a headless environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code from P10 project to translate a CPN to numeric lifted planning in PDDL.
Running
List translatable queries into stdout:
-pddl-test <model.pnml> <queries.xml>Translate the CPN and queries to a pddl domain and task into a folder "out-dir"
-pddl-out <out-dir> <model.pnml> <queries.xml>