Skip to content

[FIX] 쿼리 타입 정합성을 Long을 값 비교로 수정, 미션 단건 조회시 요청자 이름 추가 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goodjunseon merged 2 commits into from
Jan 19, 2026
Merged

[FIX] 쿼리 타입 정합성을 Long을 값 비교로 수정, 미션 단건 조회시 요청자 이름 추가 #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
811f893
fix: 쿼리 타입 정합성을 Long을 값 비교로 수정
goodjunseon Jan 19, 2026
3be7831
fix: 미션 단건 조회시 응답값에 미션 요청자의 이름을 추가
goodjunseon Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/com/oneco/backend/family/infrastructure/persistence/FamilyRelationJpaRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public interface FamilyRelationJpaRepository extends JpaRepository<FamilyRelatio
select new com.oneco.backend.StudyRecord.application.dto.result.MemberItem(m.id, m.name)
from FamilyRelation f
join Member m on m.id = f.childId.value
where f.parentId = :parentId
where f.parentId.value = :parentId
and f.status = 'CONNECTED'
""")
List<MemberItem> findAllConnectedChildrenByParentId(@Param("parentId") Long parentId);
Expand Down
9 changes: 6 additions & 3 deletions oneco/src/main/java/com/oneco/backend/mission/application/service/MissionReadService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,12 @@ public MissionDetailResponse getMissionDetailById(MemberId memberId, Long missio

String categoryTitle = categoryLookupPort.getCategoryTitle(mission.getCategoryId()).getValue();
String rewardTitle = mission.getReward() == null ? null : mission.getReward().getTitle();
String rewardMessage = mission.getReward() == null? null : mission.getReward().getMessage();
// 요청자 닉네임 조회
String rewardMessage = mission.getReward() == null ? null : mission.getReward().getMessage();
// 수신자, 요청자 닉네임 조회
Member recipient = memberJpaRepository.findById(mission.getRecipientId().getValue())
.orElseThrow(() -> BaseException.from(MissionErrorCode.MEMBER_NOT_FOUND));
Member requester = memberJpaRepository.findById(mission.getRequesterId().getValue())
.orElseThrow(() -> BaseException.from(MissionErrorCode.MEMBER_NOT_FOUND));
Comment on lines +135 to +139

Copilot AI Jan 19, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two sequential database calls are made to fetch recipient and requester members separately. Consider optimizing this by fetching both members in a single query using findAllById method, which would reduce the number of database round trips from 2 to 1.

Suggested change
// 수신자, 요청자 닉네임 조회
Member recipient = memberJpaRepository.findById(mission.getRecipientId().getValue())
.orElseThrow(() -> BaseException.from(MissionErrorCode.MEMBER_NOT_FOUND));
Member requester = memberJpaRepository.findById(mission.getRequesterId().getValue())
.orElseThrow(() -> BaseException.from(MissionErrorCode.MEMBER_NOT_FOUND));
// 수신자, 요청자 닉네임 조회 - 두 번의 단건 조회 대신 한 번의 다건 조회 사용
Long recipientId = mission.getRecipientId().getValue();
Long requesterId = mission.getRequesterId().getValue();
List<Member> members = memberJpaRepository.findAllById(Arrays.asList(recipientId, requesterId));
java.util.Map<Long, Member> memberMap = members.stream()
.collect(Collectors.toMap(member -> member.getId().getValue(), member -> member));
Member recipient = memberMap.get(recipientId);
if (recipient == null) {
throw BaseException.from(MissionErrorCode.MEMBER_NOT_FOUND);
}
Member requester = memberMap.get(requesterId);
if (requester == null) {
throw BaseException.from(MissionErrorCode.MEMBER_NOT_FOUND);
}

Copilot uses AI. Check for mistakes.
return MissionDetailResponse.of(
mission.getId(),
categoryTitle,
Expand All @@ -146,7 +148,8 @@ public MissionDetailResponse getMissionDetailById(MemberId memberId, Long missio
memberId.getValue(),
mission.getRecipientId().getValue(),
mission.getRequesterId().getValue(),
recipient.getNickname()
recipient.getNickname(),
requester.getNickname()
);
}
}
10 changes: 6 additions & 4 deletions .../src/main/java/com/oneco/backend/mission/presentation/response/MissionDetailResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ public record MissionDetailResponse(
Long memberId,
Long recipientId,
Long requesterId,
String recipientNickname
String recipientNickname,
String requesterNickname
) {
public static MissionDetailResponse of(
Long missionId,
Expand All @@ -26,9 +27,10 @@ public static MissionDetailResponse of(
Long memberId,
Long recipientId,
Long requesterId,
String recipientNickname
String recipientNickname,
String requesterNickname
) {
return new MissionDetailResponse(missionId, categoryTitle, rewardTitle,rewardMessage, startDate, endDate, missionStatus,
memberId, recipientId, requesterId, recipientNickname);
return new MissionDetailResponse(missionId, categoryTitle, rewardTitle, rewardMessage, startDate, endDate, missionStatus,
memberId, recipientId, requesterId, recipientNickname, requesterNickname);
}
}
Loading