Changes

Changes made according to inputs.
TBD54566975 · Oct 11, 2024 · ebad7de · ebad7de
1 parent 4821eb9
commit ebad7de
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 33 deletions.
diff --git a/lib/features/currency/currency_dropdown.dart b/lib/features/currency/currency_dropdown.dart
@@ -18,7 +18,6 @@ class CurrencyDropdown extends HookConsumerWidget {
   Widget build(BuildContext context, WidgetRef ref) => Directionality(
         textDirection: TextDirection.rtl,
         child: ElevatedButton.icon(
-          key: const Key('currencyDropdownButton'),
           icon: const Icon(Icons.keyboard_arrow_down),
           label: _buildCurrencyLabel(context),
           style: ElevatedButton.styleFrom(

diff --git a/test/features/currency/currency_dropdown_test.dart b/test/features/currency/currency_dropdown_test.dart
@@ -2,7 +2,7 @@ import 'package:didpay/features/currency/currency_dropdown.dart';
 import 'package:didpay/features/payment/payment_amount_state.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
-  
+
 import '../../helpers/test_data.dart';
 import '../../helpers/widget_helpers.dart';
 
@@ -13,67 +13,54 @@ void main() async {
   const testCurrency = 'USD';
 
   setUp(() {
-    // Initialize mockState with a non-null offeringsMap
     mockState = ValueNotifier<PaymentAmountState?>(
       PaymentAmountState(
         offeringsMap: TestData.getOfferingsMap(),
-      ), // Use TestData as suggested
+      ),
     );
   });
 
-  Widget createWidgetUnderTest() {
-    return WidgetHelpers.testableWidget(
-      // Use WidgetHelpers for consistent test setup
-      child: CurrencyDropdown(
-        paymentCurrency: testCurrency,
-        state: mockState,
-      ),
-    );
-  }
+  Widget currencyDropdownTestWidget() => WidgetHelpers.testableWidget(
+        child: CurrencyDropdown(
+          paymentCurrency: testCurrency,
+          state: mockState,
+        ),
+      );
 
-  testWidgets('CurrencyDropdown shows the correct initial currency',
+  testWidgets('should display the initial currency in CurrencyDropdown',
       (tester) async {
-    await tester.pumpWidget(createWidgetUnderTest());
+    await tester.pumpWidget(currencyDropdownTestWidget());
 
-    // Check if the currency label displays the initial currency
     expect(find.text(testCurrency), findsOneWidget);
   });
 
-  testWidgets('CurrencyDropdown opens the Select Currency modal when tapped',
+  testWidgets('should open Select Currency modal on tap in CurrencyDropdown',
       (tester) async {
-    await tester.pumpWidget(createWidgetUnderTest());
+    await tester.pumpWidget(currencyDropdownTestWidget());
 
-    // Tap on the currency dropdown button
     await tester.tap(find.text(testCurrency));
-    await tester.pumpAndSettle(); // Wait for the modal to open
-
-    // Verify if the modal is displayed
+    await tester.pumpAndSettle();
     expect(
       find.text('Select currency'),
       findsOneWidget,
-    ); // Look for modal text or widget
+    );
   });
 
-  testWidgets('CurrencyDropdown updates state when a currency is selected',
+  testWidgets(
+      'should update PaymentAmountState when a new offering is selected in CurrencyDropdown',
       (tester) async {
-    await tester.pumpWidget(createWidgetUnderTest());
+    await tester.pumpWidget(currencyDropdownTestWidget());
 
-    // Open the modal by tapping on the currency dropdown button
     await tester.tap(
       find.text(testCurrency),
-    ); // Using the 'USD' label text to find the button
+    );
     await tester.pumpAndSettle();
 
-    // Simulate selecting a currency by updating the mockState directly
     const selectedCurrency = 'EUR';
-    mockState.value = PaymentAmountState(
-      filterCurrency:
-          selectedCurrency, // Assuming 'filterCurrency' is the correct field for currency selection
-    );
+    await tester.tap(find.text(selectedCurrency));
 
     await tester.pumpAndSettle();
 
-    // Verify the state reflects the selected currency
     expect(mockState.value?.filterCurrency, selectedCurrency);
   });
 }