feat: add account balance widget #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
approved these changes
Jan 24, 2024
| @override | ||
| Widget build(BuildContext context) { | ||
| return Padding( | ||
| padding: const EdgeInsets.symmetric(horizontal: 20.0), |
There was a problem hiding this comment.
We should add some constants for these at some point so we don't have to duplicate this 20.0 everywhere in a future PR :)
| @@ -24,12 +24,13 @@ const lightColorScheme = ColorScheme( | |||
| onSurface: Color(0xff000000), | |||
| surfaceVariant: Color(0xffFFE8DE), | |||
| onSurfaceVariant: Color(0xff212121), | |||
| outline: Color(0xff79747E), | |||
| outline: Color(0xff333333), | |||
There was a problem hiding this comment.
Oh nice! Do we need to update these for darkColorScheme too? Or are those ok already?
There was a problem hiding this comment.
they looked ok but we may want to do a more thorough pass over this entire file later :)
Comment on lines
+18
to
+26
| testWidgets('should show SendPage when tapped', (WidgetTester tester) async { | ||
| await tester.pumpWidget( | ||
| WidgetHelpers.testableWidget(child: const AppTabs()), | ||
| ); | ||
|
|
||
| await tester.tap(find.text('Send')); | ||
| await tester.pumpAndSettle(); | ||
| expect(find.byType(SendPage), findsOneWidget); | ||
| }); |
There was a problem hiding this comment.
We could a test for the AccountBalance too if you wanna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented account balance widget containing the balance, and buttons to deposit and withdraw.
SendPagewas moved to its own tab inAppTabs