fix(web): prevent unsupported operation error in isPhysicalDevice() on web #307
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n web Added a check for kIsWeb in the DeviceInfoService to bypass the isPhysicalDevice() check on web platforms, since the app doesn't support QR code scanning on web. Now the method will return false when running on web, avoiding the unsupported operation error that occurs when trying to run device checks. - Imported 'kIsWeb' to detect web platform. - Updated isPhysicalDevice() to return false for web platform. - Ensured backward compatibility with iOS and Android platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for kIsWeb in the DeviceInfoService to bypass the
isPhysicalDevice()check on web platforms, since the app doesn't support QR code scanning on the web. Now the method will return false when running on the web, avoiding the unsupported operation error that occurs when trying to run device checks.kIsWebto detect web platform.Closes #296