Add withdraw page #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
approved these changes
Jan 30, 2024
Comment on lines
+36
to
+47
| testWidgets('should navigate to Deposit screen on tap of deposit button', | ||
| (tester) async { | ||
| await tester.pumpWidget( | ||
| WidgetHelpers.testableWidget(child: const AccountBalance()), | ||
| ); | ||
|
|
||
| await tester.tap(find.text('Deposit')); | ||
| await tester.pumpAndSettle(); | ||
|
|
||
| expect(find.byType(DepositPage), findsOneWidget); | ||
| }); | ||
|
|
Comment on lines
13
to
15
| final depositAmountPattern = RegExp(r'\$[0-9]+\.[0-9]{2}$'); | ||
|
|
||
| expect(find.textContaining(depositAmountPattern), findsExactly(2)); |
There was a problem hiding this comment.
Will these amounts not be consistent in these tests? Like can we find.text with exact matches? Or do we need the regex here.
There was a problem hiding this comment.
agree with you on exact matches, the test replacing this one (currency converter) finds exact matches but i've left in the regex, though happy to remove also! it was in the deposit page test - though i suppose its nice to confirm we have something resembling numbers showing up in the component, lol. 😆 in the new currency converter test it sits alongside expects that are looking for exact matches
|
niiiice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
currencyConvertercomponent #30