chore: update ColorScheme
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirahsapong
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
for tracking:
couple issues with the changes which is
- contrast (wcag issue) 😱
- more generally how the colours pair together (aue issue) 😅
but ofc in the interest of keeping up the awesome momentum i don't want to block merge progress if this is something that needs to get in rn! maybe we can remove the closes #18 comment at the top so we can continue to track?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open to iterating on this in the future, just needed to change secondary colors while working on #39
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-05.at.13.04.21.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-05.at.13.04.46.mp4