refactor: replaced built-in crypto library with @web5/crypto #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toheeb-Ojuolape
requested review from
mistermoe,
csuwildcat,
thehenrytsai and
LiranCohen
as code owners
|
Hi @Toheeb-Ojuolape! Thanks for this 🙏. It seems like the tests are failing around encryption, please see: |
Hi @LiranCohen thanks for your message. I have refactored my code for encryption using web5/crypto and ran the failing npm run test:node command on my local and all tests passed. I think all should be well now. Looking forward to your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR replaces the built-in crypto library with @web5/crypto in the encryption.ts file
Related Tickets & Documents
Resolves #672
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
[optional] Are there any post-deployment tasks we need to perform?
Please run npm install or make sure @web5/crypto package is installed before testing
[optional] What gif best describes this PR or how it makes you feel?