introduce npx #94
Merged
introduce npx #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
michaelneale,
mistermoe,
frankhinek,
finn-tbd,
LiranCohen and
thehenrytsai
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 80.90% 80.81% -0.09%
==========================================
Files 15 15
Lines 1000 1001 +1
Branches 100 100
==========================================
Hits 809 809
- Misses 191 192 +1 ☔ View full report in Codecov by Sentry. |
thehenrytsai
reviewed
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR
On some of our CI we run Docker which takes a whopping 7 minutes on a macOS 12 runner. Setup of docker represents almost 50% of the entire time spent waiting on some CI runs. Yet many of our projects are already Javascript + npm environments that can run
nodebinaries natively. We simplynpx @web5/dwn-serverand we're good to go. No Linux hypervisor necessary. Option for Docker will still be there for cases where it's necessary.Implementation
Add support for
npxwithbindirective. See video for local run on my machine. Validated withnpx linklocally.Video
Screen.Recording.2023-12-02.at.4.27.11.AM.mov