Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: attempt to rename grpc so v is trailing #3383

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Nov 14, 2024

WIP
Imports are broken at the moment, it seems that it wants us to refer to each imported reference fully (ie xyz/block/ftl/schema/v1/schema.Ref rather than schema.Ref

@matt2e matt2e added the skip-proto-breaking PRs with this label will skip the breaking proto check label Nov 14, 2024
@ftl-robot ftl-robot mentioned this pull request Nov 14, 2024
@alecthomas
Copy link
Collaborator

I think I've figured out what the import rules are. If you have two packages:

xyz.block.ftl.console.v1
xyz.block.ftl.schema.v1

Ad you're trying to use xyz.block.ftl.schema.v1.Schema in the console proto, you'd need to reference it like so:

schema.v1.Schema

That is, it will look for a common relative root.

@matt2e
Copy link
Collaborator Author

matt2e commented Nov 18, 2024

Doing this while #3417 is open is just going to cause more pain. I'll wait for that to come in and redo these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-proto-breaking PRs with this label will skip the breaking proto check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants