Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KBC schema #40

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Add KBC schema #40

merged 4 commits into from
Jul 13, 2024

Conversation

tomdaffurn
Copy link
Contributor

No description provided.

@frankhinek
Copy link
Contributor

@tomdaffurn @mistermoe Should we rename this repo to be more generalized if we're going to include both KCC and KBC specs / schemas? Similar to the issue @decentralgabe raised.

Another thought is that we could create a schemas or json-schemas sub-directory in this repo, which would make it simpler for automating hosting.

kbc.schema.json Outdated
@@ -0,0 +1,54 @@
{
"$schema":"https://json-schema.org/draft/2020-12/schema",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we used this version everywhere, just noting that the other schemas use draft 7.

I'd recommend keeping this and let's take an action to update the other schemas.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to make sure our libs are set up to handle 2020-12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib support for 2020-12 is largely untested at the moment. we know for a fact that 07 works. if we can get someone with cycles to test 2020-12 across several languages or even just rust, js, go, and dart that'd be awesome

kbc.schema.json Outdated
{
"$schema":"https://json-schema.org/draft/2020-12/schema",
"type":"object",
"properties":{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also add id as a top level required property?

kbc.schema.json Outdated
},
"issuanceDate":{
"type":"string",
"format":"date-time"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noting that the regex for date-time is not quite conformant to xml date time as required by the spec

you can find a full regex for xml date time here https://github.com/w3c/vc-data-model/blob/main/schema/verifiable-credential/verifiable-credential-schema.json#L216

@tomdaffurn
Copy link
Contributor Author

@tomdaffurn @mistermoe Should we rename this repo to be more generalized if we're going to include both KCC and KBC specs / schemas? Similar to the issue @decentralgabe raised.

Another thought is that we could create a schemas or json-schemas sub-directory in this repo, which would make it simpler for automating hosting.

Moved to a dir 👍 We should have a conversation about where the schemas should live. I'll post about it elsewhere

Copy link
Member

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hesitant about 2020-12 for the reasons explained in the comments i left. aside from that looks good!

@frankhinek frankhinek merged commit 2290d69 into main Jul 13, 2024
@frankhinek frankhinek deleted the tom/kbc-schema branch July 13, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants