Fix/did web create key (#461) #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* owner jwk id and controller strings were mixed up * did peer jwk id and controller strings were mixed up * add tests to check for owner key in DID Web Create * add tests to check verification method controller in did peer resolver --------- Co-authored-by: Liran Cohen <[email protected]>
decentralgabe
requested review from
nitro-neal and
andresuribe87
as code owners
Codecov Report
@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 57.23% 57.23%
=======================================
Files 67 67
Lines 7494 7494
=======================================
Hits 4289 4289
Misses 2468 2468
Partials 737 737
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge in #430