Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logic with sdk functions #578

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

andresuribe87
Copy link
Contributor

@andresuribe87 andresuribe87 commented Jul 7, 2023

Overview

Fixes #122 by including the changes from TBD54566975/ssi-sdk#424

Description

Just removed an impl.

How Has This Been Tested?

Just implementation changes. All tests pass.

@andresuribe87 andresuribe87 marked this pull request as ready for review July 7, 2023 20:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #578 (03dec5e) into main (e7d184d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   24.00%   24.00%           
=======================================
  Files          46       46           
  Lines        5312     5312           
=======================================
  Hits         1275     1275           
  Misses       3799     3799           
  Partials      238      238           

@andresuribe87 andresuribe87 merged commit a5997da into TBD54566975:main Jul 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move verification logic to the ssi-sdk
3 participants