Separates service internal namespace from externally added keys. #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
approved these changes
Jul 10, 2023
pkg/service/keystore/storage.go
Outdated
| @@ -55,6 +55,7 @@ type ServiceKey struct { | |||
|
|
|||
| const ( | |||
| namespace = "keystore" | |||
| serviceNamespace = "keystore:service-internal" | |||
There was a problem hiding this comment.
I thought we were using - instead of : in other places, may want to make sure this is uniform
There was a problem hiding this comment.
It was a mix. I've changed it so we're using : everywhere
decentralgabe
approved these changes
Jul 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 24.00% 23.96% -0.04%
==========================================
Files 46 46
Lines 5312 5303 -9
==========================================
- Hits 1275 1271 -4
+ Misses 3799 3794 -5
Partials 238 238
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #367 by changing the namespace that the service key uses.
Description
na
How Has This Been Tested?
All tests pass.