adding in seperate status base URI #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
- Coverage 25.55% 25.54% -0.02%
==========================================
Files 56 56
Lines 6299 6311 +12
==========================================
+ Hits 1610 1612 +2
- Misses 4413 4421 +8
- Partials 276 278 +2
|
Co-authored-by: Gabe <[email protected]>
Co-authored-by: Gabe <[email protected]>
Co-authored-by: Gabe <[email protected]>
|
@decentralgabe yeah made those changes, sorry didn't get to add tests specifically for this. |
michaelneale
requested review from
nitro-neal and
andresuribe87
as code owners
decentralgabe
approved these changes
Aug 18, 2023
* tmp * fix tests * fix int test * fix config
| @@ -208,6 +209,13 @@ func CredentialAPI(rg *gin.RouterGroup, service svcframework.Service, webhookSer | |||
| // make sure the credential service is configured to use the correct path | |||
| config.SetServicePath(svcframework.Credential, CredentialsPrefix) | |||
|
|
|||
| // allows for a custom URI to be used for status list credentials, if not set, we use the default path | |||
| if statusEndpoint != "" { | |||
There was a problem hiding this comment.
this needs to be initialized after the cred prefix is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing: #640
@decentralgabe am I on the right track?