Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to use t *testing.T instead of tt *testing.T #717

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

atsushii
Copy link
Contributor

@atsushii atsushii commented Dec 5, 2023

Overview

fix tests to use t *testing.T instead of tt *testing.T

Description

Addresses #634

How Has This Been Tested?

Run existing test with mage test cmd

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING document.
  • My code is consistent with the rest of the project
  • I have tagged the relevant reviewers and/or interested parties
  • I have updated the READMEs and other documentation of affected packages

References

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11e9266) 25.51% compared to head (cb7d150) 25.51%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   25.51%   25.51%           
=======================================
  Files          56       56           
  Lines        6309     6309           
=======================================
  Hits         1610     1610           
  Misses       4421     4421           
  Partials      278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decentralgabe decentralgabe merged commit 8f87d43 into TBD54566975:main Dec 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants