PR changes

TBD54566975 · Dec 12, 2023 · 6d66eee · 6d66eee
1 parent 2f4d397
commit 6d66eee
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/packages/http-server/src/request-handlers/submit-close.ts b/packages/http-server/src/request-handlers/submit-close.ts
@@ -30,7 +30,7 @@ export function submitClose(opts: SubmitCloseOpts): RequestHandler {
 
     const exchange = await exchangesApi.getExchange({id: message.exchangeId})
     if(exchange == undefined) {
-      const errorResponse: ErrorDetail = { detail: `exchangeId: ${message.exchangeId} is undefined` }
+      const errorResponse: ErrorDetail = { detail: `No exchange found for ${message.exchangeId}` }
 
       return res.status(404).json({ errors: [errorResponse] })
     }

diff --git a/packages/http-server/src/request-handlers/submit-order.ts b/packages/http-server/src/request-handlers/submit-order.ts
@@ -30,13 +30,11 @@ export function submitOrder(opts: SubmitOrderOpts): RequestHandler {
 
     const exchange = await exchangesApi.getExchange({id: message.exchangeId})
     if(exchange == undefined) {
-      const errorResponse: ErrorDetail = { detail: `exchangeId: ${message.exchangeId} is undefined` }
+      const errorResponse: ErrorDetail = { detail: `No exchange found for ${message.exchangeId}` }
 
       return res.status(404).json({ errors: [errorResponse] })
     }
 
-    console.log('hiiiii')
-
     const last = exchange[exchange.length-1]
     if(!last.validNext.has('order')) {
       const errorResponse: ErrorDetail = { detail: `cannot submit Order for an exchange where the last message is kind: ${last.kind}` }

diff --git a/packages/http-server/tests/submit-close.spec.ts b/packages/http-server/tests/submit-close.spec.ts
@@ -73,7 +73,7 @@ describe('POST /exchanges/:exchangeId/close', () => {
 
     const [ error ] = responseBody.errors
     expect(error.detail).to.exist
-    expect(error.detail).to.include('is undefined')
+    expect(error.detail).to.include('No exchange found for')
   })
 
   xit(`returns a 409 if close is not allowed based on the exchange's current state`, async () => {

diff --git a/packages/http-server/tests/submit-order.spec.ts b/packages/http-server/tests/submit-order.spec.ts
@@ -72,7 +72,7 @@ describe('POST /exchanges/:exchangeId/order', () => {
 
     const [ error ] = responseBody.errors
     expect(error.detail).to.exist
-    expect(error.detail).to.include('is undefined')
+    expect(error.detail).to.include('No exchange found for')
   })
 
   xit(`returns a 409 if order is not allowed based on the exchange's current state`)