Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HttpResponse and ErrorResponse from http-client types #124

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Remove HttpResponse and ErrorResponse from http-client types #124

merged 4 commits into from
Jan 4, 2024

Conversation

kirahsapong
Copy link
Contributor

@kirahsapong kirahsapong commented Dec 20, 2023 •
edited
Loading

Closes #123

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4d34cc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tbdex/http-client Patch
@tbdex/http-server Patch
@tbdex/protocol Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2023-12-20T19:50:20Z 4d34cc5

jiyoontbd
jiyoontbd approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@jiyoontbd jiyoontbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@kirahsapong kirahsapong merged commit 47105ca into main Jan 4, 2024
7 checks passed
@kirahsapong kirahsapong deleted the feat/cleanup-http-client-types branch January 4, 2024 19:04
diehuxx added a commit that referenced this pull request Jan 4, 2024
@diehuxx
Merge branch 'main' into vectors-214
27f4ffe 
* main:
  Remove HttpResponse and ErrorResponse from `http-client` types (#124)
  Refactor http client to introduce custom error types (#113)
  Finish validating rfq against provided offering (#120)
  Generates the HTML to publish to GH Pages (#116)
  http-server fixes + some tests (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KendallWeihe KendallWeihe KendallWeihe approved these changes

@jiyoontbd jiyoontbd jiyoontbd approved these changes

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor http-server tests to remove ErrorResponse
3 participants
@kirahsapong @KendallWeihe @jiyoontbd